Address some more analyzer warnings (#47)

Author: stephentoub

src/Custom/Assistants/AssistantResponseFormat.cs

@@ -73,15 +73,15 @@ internal AssistantResponseFormat(string plainTextValue, string objectType, IDict
     /// <inheritdoc />
     public static implicit operator AssistantResponseFormat(string value)
     {
-        if (string.Equals(value, AutoValue, StringComparison.InvariantCultureIgnoreCase))
+        if (string.Equals(value, AutoValue, StringComparison.OrdinalIgnoreCase))
         {
             return Auto;
         }
-        if (string.Equals(value, TextValue, StringComparison.InvariantCultureIgnoreCase))
+        if (string.Equals(value, TextValue, StringComparison.OrdinalIgnoreCase))
         {
             return Text;
         }
-        if (string.Equals(value, JsonObjectValue, StringComparison.InvariantCultureIgnoreCase))
+        if (string.Equals(value, JsonObjectValue, StringComparison.OrdinalIgnoreCase))
         {
             return JsonObject;
         }

src/Custom/Audio/AudioTranscription.Serialization.cs

@@ -9,7 +9,8 @@ public partial class AudioTranscription
     internal static AudioTranscription FromResponse(PipelineResponse response)
     {
         // Customization: handle plain text responses (SRT/VTT formats)
-        if (response?.Headers?.TryGetValue("Content-Type", out string contentType) == true && contentType.StartsWith("text/plain"))
+        if (response?.Headers?.TryGetValue("Content-Type", out string contentType) == true &&
+            contentType.StartsWith("text/plain", StringComparison.Ordinal))
         {
             return new AudioTranscription(
                 InternalCreateTranscriptionResponseVerboseJsonTask.Transcribe,

src/Custom/Audio/AudioTranslation.Serialization.cs

@@ -9,7 +9,8 @@ public partial class AudioTranslation
     internal static AudioTranslation FromResponse(PipelineResponse response)
     {
         // Customization: handle plain text responses (SRT/VTT formats)
-        if (response?.Headers?.TryGetValue("Content-Type", out string contentType) == true && contentType.StartsWith("text/plain"))
+        if (response?.Headers?.TryGetValue("Content-Type", out string contentType) == true &&
+            contentType.StartsWith("text/plain", StringComparison.Ordinal))
         {
             return new AudioTranslation(
                 InternalCreateTranslationResponseVerboseJsonTask.Translate,

src/Custom/Chat/ChatCompletionOptions.Serialization.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Globalization;
 using System.Runtime.CompilerServices;
 using System.Text.Json;
 
@@ -49,7 +50,7 @@ private void SerializeLogitBiasesValue(Utf8JsonWriter writer)
         writer.WriteStartObject();
         foreach (var item in LogitBiases)
         {
-            writer.WritePropertyName(item.Key.ToString());
+            writer.WritePropertyName(item.Key.ToString(CultureInfo.InvariantCulture));
             writer.WriteNumberValue(item.Value);
         }
         writer.WriteEndObject();
@@ -68,7 +69,7 @@ private static void DeserializeLogitBiasesValue(JsonProperty property, ref IDict
             Dictionary<int, int> dictionary = new Dictionary<int, int>();
             foreach (var property0 in property.Value.EnumerateObject())
             {
-                dictionary.Add(int.Parse(property0.Name), property0.Value.GetInt32());
+                dictionary.Add(int.Parse(property0.Name, CultureInfo.InvariantCulture), property0.Value.GetInt32());
             }
             logitBias = dictionary;
         }

src/Custom/Chat/Internal/InternalChatCompletionRequestMessageContentPartImageImageUrl.cs

@@ -16,9 +16,9 @@ internal partial class InternalChatCompletionRequestMessageContentPartImageImage
     private static readonly Regex s_parseDataUriRegex = new(@"^data:(?<type>.+?);base64,(?<data>.+)$", RegexOptions.Compiled);
 #endif
 
-    private readonly Uri _imageUri = default;
-    private readonly BinaryData _imageBytes = default;
-    private readonly string _imageBytesMediaType = default;
+    private readonly Uri _imageUri;
+    private readonly BinaryData _imageBytes;
+    private readonly string _imageBytesMediaType;
 
     // CUSTOM: Changed type from Uri to string to be able to support data URIs properly.
     /// <summary> Either a URL of the image or the base64 encoded image data. </summary>

src/Custom/Embeddings/Embedding.cs

@@ -91,7 +91,7 @@ internal Embedding(int index, BinaryData embeddingProperty, InternalEmbeddingObj
     public ReadOnlyMemory<float> Vector { get; }
 
     // CUSTOM: Implemented custom logic to transform from BinaryData to ReadOnlyMemory<float>.
-    private ReadOnlyMemory<float> ConvertToVectorOfFloats(BinaryData binaryData)
+    private static ReadOnlyMemory<float> ConvertToVectorOfFloats(BinaryData binaryData)
     {
         ReadOnlySpan<byte> base64 = binaryData.ToMemory().Span;
 

src/Custom/OpenAIClient.cs

@@ -46,25 +46,6 @@ public partial class OpenAIClient
 {
     private readonly OpenAIClientOptions _options;
 
-    // CUSTOM: Applied the Experimental attribute as needed.
-    private AudioClient _cachedAudioClient;
-    [Experimental("OPENAI001")]
-    private AssistantClient _cachedAssistantClient;
-    private BatchClient _cachedBatchClient;
-    private ChatClient _cachedChatClient;
-    private LegacyCompletionClient _cachedLegacyCompletionClient;
-    private EmbeddingClient _cachedEmbeddingClient;
-    private FileClient _cachedFileClient;
-    private FineTuningClient _cachedFineTuningClient;
-    private ImageClient _cachedImageClient;
-    private InternalAssistantMessageClient _cachedInternalAssistantMessageClient;
-    private ModelClient _cachedModelClient;
-    private ModerationClient _cachedModerationClient;
-    private InternalAssistantRunClient _cachedInternalAssistantRunClient;
-    private InternalAssistantThreadClient _cachedInternalAssistantThreadClient;
-    [Experimental("OPENAI001")]
-    private VectorStoreClient _cachedVectorStoreClient;
-
     /// <summary>
     /// The configured connection endpoint.
     /// </summary>

src/Custom/OpenAIError.cs

@@ -35,10 +35,10 @@ OpenAIErrorResponse errorResponse
     public string ToExceptionMessage(int httpStatus)
     {
         StringBuilder messageBuilder = new();
-        messageBuilder.AppendLine($"HTTP {httpStatus} ({Type}: {Code})");
+        messageBuilder.Append("HTTP ").Append(httpStatus).Append(" (").Append(Type).Append(": ").Append(Code).AppendLine(")");
         if (!string.IsNullOrEmpty(Param))
         {
-            messageBuilder.AppendLine($"Parameter: {Param}");
+            messageBuilder.Append("Parameter: ").AppendLine(Param);
         }
         messageBuilder.AppendLine();
         messageBuilder.Append(Message);

src/Utility/Generator/CodeGenClientAttribute.cs

@@ -5,7 +5,7 @@
 namespace OpenAI;
 
 [AttributeUsage(AttributeTargets.Class)]
-internal class CodeGenClientAttribute : CodeGenTypeAttribute
+internal sealed class CodeGenClientAttribute : CodeGenTypeAttribute
 {
     public Type? ParentClient { get; set; }
 

src/Utility/Generator/CodeGenMemberAttribute.cs

@@ -5,7 +5,7 @@
 namespace OpenAI;
 
 [AttributeUsage(AttributeTargets.Property | AttributeTargets.Field)]
-internal class CodeGenMemberAttribute : CodeGenTypeAttribute
+internal sealed class CodeGenMemberAttribute : CodeGenTypeAttribute
 {
     public CodeGenMemberAttribute() : base(null)
     {

src/Utility/Generator/CodeGenModelAttribute.cs

@@ -5,7 +5,7 @@
 namespace OpenAI;
 
 [AttributeUsage(AttributeTargets.Class | AttributeTargets.Enum | AttributeTargets.Struct)]
-internal class CodeGenModelAttribute : CodeGenTypeAttribute
+internal sealed class CodeGenModelAttribute : CodeGenTypeAttribute
 {
     /// <summary>
     /// Gets or sets a coma separated list of additional model usage modes. Allowed values: model, error, intput, output.

src/Utility/Generator/CodeGenSerializationAttribute.cs

@@ -5,7 +5,7 @@
 namespace OpenAI;
 
 [AttributeUsage(AttributeTargets.Class | AttributeTargets.Struct, AllowMultiple = true, Inherited = true)]
-internal class CodeGenSerializationAttribute : Attribute
+internal sealed class CodeGenSerializationAttribute : Attribute
 {
     /// <summary>
     /// Gets or sets the property name which these hooks should apply to

src/Utility/Generator/CodeGenSuppressAttribute.cs

@@ -3,7 +3,7 @@
 namespace OpenAI;
 
 [AttributeUsage(AttributeTargets.Class | AttributeTargets.Enum | AttributeTargets.Struct, AllowMultiple = true)]
-internal class CodeGenSuppressAttribute : Attribute
+internal sealed class CodeGenSuppressAttribute : Attribute
 {
     public string Member { get; }
     public Type[] Parameters { get; }