fix(query): stop including undefined keys

Author: zkat

Diff for: index.js

@@ -56,13 +56,20 @@ function regFetch (uri, opts) {
     if (typeof q === 'string') {
       q = qs.parse(q)
     }
-    const parsed = url.parse(uri)
-    parsed.search = '?' + qs.stringify(
-      parsed.query
-        ? Object.assign(qs.parse(parsed.query), q)
-        : q
-    )
-    uri = url.format(parsed)
+    Object.keys(q).forEach(key => {
+      if (q[key] === undefined) {
+        delete q[key]
+      }
+    })
+    if (Object.keys(q).length) {
+      const parsed = url.parse(uri)
+      parsed.search = '?' + qs.stringify(
+        parsed.query
+          ? Object.assign(qs.parse(parsed.query), q)
+          : q
+      )
+      uri = url.format(parsed)
+    }
   }
   return opts.Promise.resolve(body).then(body => fetch(uri, {
     agent: opts.agent,

Diff for: test/index.js

@@ -220,6 +220,16 @@ test('query strings', t => {
     .then(json => t.equal(json.hello, 'world', 'query-string merged'))
 })
 
+test('query strings - undefined values', t => {
+  tnock(t, OPTS.registry)
+    .get('/hello?who=wor%20ld')
+    .reply(200, {ok: true})
+  return fetch.json('/hello', Object.assign({
+    query: {hi: undefined, who: 'wor ld'}
+  }, OPTS))
+    .then(json => t.ok(json.ok, 'undefined keys not included in query string'))
+})
+
 test('json()', t => {
   tnock(t, OPTS.registry)
     .get('/hello')