Reset ethers provider after a hardhat_reset #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
commented
Nov 16, 2020
| @@ -58,6 +58,10 @@ export class HttpProvider extends EventEmitter implements EIP1193Provider { | |||
| throw error; | |||
| } | |||
|
|
|||
| if (args.method === "hardhat_reset") { | |||
| this.emit("hardhat_reset"); | |||
There was a problem hiding this comment.
Not sure about the name of this event.
There was a problem hiding this comment.
maybe hardhatNetwokReset? I'd create a constant.
alcuadrado
reviewed
Nov 18, 2020
| } | ||
|
|
||
| if (args.method === "hardhat_reset") { | ||
| this.emit("hardhat_reset"); |
There was a problem hiding this comment.
Shouldn't we emit it in the node and just fwd it in the provider?
There was a problem hiding this comment.
As far as I understand, a new node is created on a reset, so that wouldn't be possible, would it?
alcuadrado
approved these changes
Nov 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1015
There are a lot of changes in the test file, but they are mostly whitespace because of an extra
describeblock around them.