From 029eb6ec477921c1e0a9b42fe2f46c15d47655c2 Mon Sep 17 00:00:00 2001 From: JonasBa Date: Fri, 14 Mar 2025 14:10:52 -0400 Subject: [PATCH] build: fix update-wpt workflow --- .github/workflows/update-wpt.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/update-wpt.yml b/.github/workflows/update-wpt.yml index 77f0577bb68c8d..766155b49ec638 100644 --- a/.github/workflows/update-wpt.yml +++ b/.github/workflows/update-wpt.yml @@ -70,7 +70,11 @@ jobs: - name: Open or update PR for the subsystem update uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5 with: - branch: actions/update-wpt-${{ matrix.subsystem }} + # The create-or-update-pull-request-action matches the branch name by prefix, + # which is why we need to add the -wpt suffix. If we dont do that, we risk matching wrong PRs, + # like for example "url" mistakenly matching and updating the "urlpattern" PR + # as seen in https://github.com/nodejs/node/pull/57368 + branch: actions/update-${{ matrix.subsystem }}-wpt author: Node.js GitHub Bot title: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}' commit-message: 'test: update WPT for ${{ matrix.subsystem }} to ${{ env.short_version }}'