test: fix test-http2-reset-flood flakiness

addaleax · MylesBorins · commit eee587b84774 · 2020-04-02T00:47:08.000-04:00
Refs: #29802 (comment) PR-URL: #32607 Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/test/parallel/test-http2-reset-flood.js b/test/parallel/test-http2-reset-flood.js
@@ -69,9 +69,10 @@ const worker = new Worker(__filename).on('message', common.mustCall((port) => {
       h2header.writeIntBE(streamId, 5, 4);  // Stream ID
       streamId += 2;
       // 0x88 = :status: 200
-      conn.write(Buffer.concat([h2header, Buffer.from([0x88])]));
+      if (conn.writable)
+        conn.write(Buffer.concat([h2header, Buffer.from([0x88])]));
     }
-    if (!gotError)
+    if (conn.writable && !gotError)
       setImmediate(writeRequests);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -69,9 +69,10 @@ const worker = new Worker(__filename).on('message', common.mustCall((port) => {`
`69`	`69`	`h2header.writeIntBE(streamId, 5, 4); // Stream ID`
`70`	`70`	`streamId += 2;`
`71`	`71`	`// 0x88 = :status: 200`
`72`		`- conn.write(Buffer.concat([h2header, Buffer.from([0x88])]));`
	`72`	`+ if (conn.writable)`
	`73`	`+ conn.write(Buffer.concat([h2header, Buffer.from([0x88])]));`
`73`	`74`	`}`
`74`		`- if (!gotError)`
	`75`	`+ if (conn.writable && !gotError)`
`75`	`76`	`setImmediate(writeRequests);`
`76`	`77`	`}`
`77`	`78`