Skip to content

Commit e9110d5

Browse files
committed
process: do not lazily load AsyncResource
It doesn't seem necessary. PR-URL: #38041 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent aff0cd3 commit e9110d5

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

lib/internal/process/task_queues.js

+8-11
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ const {
3939
} = require('internal/errors').codes;
4040
const FixedQueue = require('internal/fixed_queue');
4141

42+
const { AsyncResource } = require('async_hooks');
43+
4244
// *Must* match Environment::TickInfo::Fields in src/env.h.
4345
const kHasTickScheduled = 0;
4446

@@ -132,16 +134,6 @@ function nextTick(callback) {
132134
queue.push(tickObject);
133135
}
134136

135-
let AsyncResource;
136-
const defaultMicrotaskResourceOpts = { requireManualDestroy: true };
137-
function createMicrotaskResource() {
138-
// Lazy load the async_hooks module
139-
if (AsyncResource === undefined) {
140-
AsyncResource = require('async_hooks').AsyncResource;
141-
}
142-
return new AsyncResource('Microtask', defaultMicrotaskResourceOpts);
143-
}
144-
145137
function runMicrotask() {
146138
this.runInAsyncScope(() => {
147139
const callback = this.callback;
@@ -153,12 +145,17 @@ function runMicrotask() {
153145
});
154146
}
155147

148+
const defaultMicrotaskResourceOpts = { requireManualDestroy: true };
149+
156150
function queueMicrotask(callback) {
157151
if (typeof callback !== 'function') {
158152
throw new ERR_INVALID_ARG_TYPE('callback', 'function', callback);
159153
}
160154

161-
const asyncResource = createMicrotaskResource();
155+
const asyncResource = new AsyncResource(
156+
'Microtask',
157+
defaultMicrotaskResourceOpts
158+
);
162159
asyncResource.callback = callback;
163160

164161
enqueueMicrotask(FunctionPrototypeBind(runMicrotask, asyncResource));

test/parallel/test-bootstrap-modules.js

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ const expectedModules = new Set([
3131
'Internal Binding types',
3232
'Internal Binding url',
3333
'Internal Binding util',
34+
'NativeModule async_hooks',
3435
'NativeModule buffer',
3536
'NativeModule events',
3637
'NativeModule fs',

0 commit comments

Comments
 (0)