Skip to content

Commit e8f8c70

Browse files
danbevtargos
authored andcommitted
src: remove unnecessary ToLocalChecked call
PR-URL: #36523 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 9b13ddc commit e8f8c70

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/node_buffer.cc

+4-3
Original file line numberDiff line numberDiff line change
@@ -495,18 +495,19 @@ void StringSlice(const FunctionCallbackInfo<Value>& args) {
495495
size_t length = end - start;
496496

497497
Local<Value> error;
498-
MaybeLocal<Value> ret =
498+
MaybeLocal<Value> maybe_ret =
499499
StringBytes::Encode(isolate,
500500
buffer.data() + start,
501501
length,
502502
encoding,
503503
&error);
504-
if (ret.IsEmpty()) {
504+
Local<Value> ret;
505+
if (!maybe_ret.ToLocal(&ret)) {
505506
CHECK(!error.IsEmpty());
506507
isolate->ThrowException(error);
507508
return;
508509
}
509-
args.GetReturnValue().Set(ret.ToLocalChecked());
510+
args.GetReturnValue().Set(ret);
510511
}
511512

512513

0 commit comments

Comments
 (0)