benchmark: swap var for let in benchmarks

In benchmark directory this changes for loops
using var to let when it applies for consistency

PR-URL: #28958
Reviewed-By: Anna Henningsen <[email protected]>

Author: RamirezAlex

benchmark/module/module-loader-deep.js

@@ -19,7 +19,7 @@ function main({ ext, cache, files }) {
     `${benchmarkDirectory}/a.js`,
     'module.exports = {};'
   );
-  for (var i = 0; i <= files; i++) {
+  for (let i = 0; i <= files; i++) {
     fs.mkdirSync(`${benchmarkDirectory}/${i}`);
     fs.writeFileSync(
       `${benchmarkDirectory}/${i}/package.json`,

benchmark/module/module-loader.js

@@ -21,7 +21,7 @@ const bench = common.createBenchmark(main, {
 function main({ n, name, cache, files, dir }) {
   tmpdir.refresh();
   fs.mkdirSync(benchmarkDirectory);
-  for (var i = 0; i <= files; i++) {
+  for (let i = 0; i <= files; i++) {
     fs.mkdirSync(`${benchmarkDirectory}${i}`);
     fs.writeFileSync(
       `${benchmarkDirectory}${i}/package.json`,

benchmark/os/cpus.js

@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; ++i)
+  for (let i = 0; i < n; ++i)
     cpus();
   bench.end(n);
 }

benchmark/os/loadavg.js

@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; ++i)
+  for (let i = 0; i < n; ++i)
     loadavg();
   bench.end(n);
 }

benchmark/os/networkInterfaces.js

@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; ++i)
+  for (let i = 0; i < n; ++i)
     networkInterfaces();
   bench.end(n);
 }

benchmark/path/basename-posix.js

@@ -27,7 +27,7 @@ function main({ n, pathext }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.basename(i % 3 === 0 ? `${pathext}${i}` : pathext, ext);
   }
   bench.end(n);

benchmark/path/basename-win32.js

@@ -27,7 +27,7 @@ function main({ n, pathext }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.basename(i % 3 === 0 ? `${pathext}${i}` : pathext, ext);
   }
   bench.end(n);

benchmark/path/dirname-posix.js

@@ -17,7 +17,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.dirname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/dirname-win32.js

@@ -17,7 +17,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.dirname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/extname-posix.js

@@ -20,7 +20,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.extname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/extname-win32.js

@@ -20,7 +20,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.extname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/format-posix.js

@@ -20,7 +20,7 @@ function main({ n, props }) {
   };
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     obj.base = `a${i}${props[2] || ''}`;
     obj.name = `a${i}${props[4] || ''}`;
     posix.format(obj);

benchmark/path/format-win32.js

@@ -20,7 +20,7 @@ function main({ n, props }) {
   };
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     obj.base = `a${i}${props[2] || ''}`;
     obj.name = `a${i}${props[4] || ''}`;
     win32.format(obj);

benchmark/path/isAbsolute-posix.js

@@ -15,7 +15,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.isAbsolute(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/isAbsolute-win32.js

@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.isAbsolute(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/join-posix.js

@@ -15,7 +15,7 @@ function main({ n, paths }) {
   const orig = copy[1];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[1] = `${orig}${i}`;
       posix.join(...copy);

benchmark/path/join-win32.js

@@ -15,7 +15,7 @@ function main({ n, paths }) {
   const orig = copy[1];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[1] = `${orig}${i}`;
       win32.join(...copy);

benchmark/path/makeLong-win32.js

@@ -14,7 +14,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32._makeLong(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/normalize-posix.js

@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.normalize(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/normalize-win32.js

@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.normalize(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/resolve-posix.js

@@ -18,7 +18,7 @@ function main({ n, paths }) {
   const orig = copy[0];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[0] = `${orig}${i}`;
       posix.resolve(...copy);

benchmark/path/resolve-win32.js

@@ -18,7 +18,7 @@ function main({ n, paths }) {
   const orig = copy[0];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[0] = `${orig}${i}`;
       win32.resolve(...copy);

benchmark/process/memoryUsage.js

@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     process.memoryUsage();
   }
   bench.end(n);

benchmark/process/next-tick-breadth-args.js

@@ -33,7 +33,7 @@ function main({ n }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 4 === 0)
       process.nextTick(cb4, 3.14, 1024, true, false);
     else if (i % 3 === 0)

benchmark/process/next-tick-breadth.js

@@ -15,7 +15,7 @@ function main({ n }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     process.nextTick(cb);
   }
 }

benchmark/process/next-tick-exec-args.js

@@ -10,7 +10,7 @@ function main({ n }) {
       bench.end(n);
   }
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 4 === 0)
       process.nextTick(onNextTick, i, true, 10, 'test');
     else if (i % 3 === 0)

benchmark/process/next-tick-exec.js

@@ -10,7 +10,7 @@ function main({ n }) {
       bench.end(n);
   }
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     process.nextTick(onNextTick, i);
   }
 

benchmark/process/queue-microtask-breadth.js

@@ -15,7 +15,7 @@ function main({ n }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     queueMicrotask(cb);
   }
 }

benchmark/querystring/querystring-stringify.js

@@ -38,7 +38,7 @@ function main({ type, n }) {
     querystring.stringify(inputs[name]);
 
   bench.start();
-  for (var i = 0; i < n; i += 1)
+  for (let i = 0; i < n; i += 1)
     querystring.stringify(input);
   bench.end(n);
 }

benchmark/querystring/querystring-unescapebuffer.js

@@ -14,7 +14,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ input, n }) {
   bench.start();
-  for (var i = 0; i < n; i += 1)
+  for (let i = 0; i < n; i += 1)
     querystring.unescapeBuffer(input);
   bench.end(n);
 }

benchmark/string_decoder/string-decoder-create.js

@@ -11,7 +11,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ encoding, n }) {
   bench.start();
-  for (var i = 0; i < n; ++i) {
+  for (let i = 0; i < n; ++i) {
     const sd = new StringDecoder(encoding);
     !!sd.encoding;
   }

benchmark/timers/immediate.js

@@ -66,7 +66,7 @@ function breadth(N) {
     if (n === N)
       bench.end(N);
   }
-  for (var i = 0; i < N; i++) {
+  for (let i = 0; i < N; i++) {
     setImmediate(cb);
   }
 }
@@ -80,7 +80,7 @@ function breadth1(N) {
     if (n === N)
       bench.end(n);
   }
-  for (var i = 0; i < N; i++) {
+  for (let i = 0; i < N; i++) {
     setImmediate(cb, 1);
   }
 }
@@ -95,7 +95,7 @@ function breadth4(N) {
     if (n === N)
       bench.end(n);
   }
-  for (var i = 0; i < N; i++) {
+  for (let i = 0; i < N; i++) {
     setImmediate(cb, 1, 2, 3, 4);
   }
 }
@@ -107,7 +107,7 @@ function clear(N) {
     if (a1 === 2)
       bench.end(N);
   }
-  for (var i = 0; i < N; i++) {
+  for (let i = 0; i < N; i++) {
     clearImmediate(setImmediate(cb, 1));
   }
   setImmediate(cb, 2);

benchmark/timers/timers-breadth-args.js

@@ -32,7 +32,7 @@ function main({ n }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 4 === 0)
       setTimeout(cb4, 1, 3.14, 1024, true, false);
     else if (i % 3 === 0)

benchmark/timers/timers-breadth.js

@@ -13,7 +13,7 @@ function main({ n }) {
     if (j === n)
       bench.end(n);
   }
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     setTimeout(cb, 1);
   }
 }

benchmark/timers/timers-cancel-pooled.js

@@ -9,15 +9,15 @@ const bench = common.createBenchmark(main, {
 function main({ n }) {
 
   var timer = setTimeout(() => {}, 1);
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     setTimeout(cb, 1);
   }
   var next = timer._idlePrev;
   clearTimeout(timer);
 
   bench.start();
 
-  for (var j = 0; j < n; j++) {
+  for (let j = 0; j < n; j++) {
     timer = next;
     next = timer._idlePrev;
     clearTimeout(timer);

benchmark/timers/timers-cancel-unpooled.js

@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
 function main({ n, direction }) {
 
   const timersList = [];
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     timersList.push(setTimeout(cb, i + 1));
   }
 

benchmark/timers/timers-insert-pooled.js

@@ -9,7 +9,7 @@ function main({ n }) {
 
   bench.start();
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     setTimeout(() => {}, 1);
   }
 

benchmark/timers/timers-insert-unpooled.js

@@ -23,7 +23,7 @@ function main({ direction, n }) {
   }
   bench.end(n);
 
-  for (var j = 0; j < n; j++) {
+  for (let j = 0; j < n; j++) {
     clearTimeout(timersList[j]);
   }
 }

benchmark/timers/timers-timeout-nexttick.js

@@ -30,7 +30,7 @@ function main({ n }) {
       bench.end(n);
   }
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     setTimeout(i % 2 ? cb : cb2, 1);
   }
 

benchmark/timers/timers-timeout-pooled.js

@@ -27,7 +27,7 @@ function main({ n }) {
       bench.end(n);
   }
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     setTimeout(i % 2 ? cb : cb2, 1);
   }