Skip to content

Commit d8f8719

Browse files
committed
build: do not pass mode option to test-v8 command
It was removed upstream and is now inferred from the build config. PR-URL: #35705 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #38275 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
1 parent 329ee8b commit d8f8719

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -648,8 +648,7 @@ test-with-async-hooks:
648648
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
649649
# Related CI job: node-test-commit-v8-linux
650650
test-v8: v8 ## Runs the V8 test suite on deps/v8.
651-
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
652-
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) \
651+
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \
653652
mjsunit cctest debugger inspector message preparser \
654653
$(TAP_V8)
655654
$(info Testing hash seed)

0 commit comments

Comments
 (0)