Skip to content

Commit cd9770c

Browse files
committed
src: make minor cleanups in encoding_binding.cc
1 parent 12c90bb commit cd9770c

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/encoding_binding.cc

+7-5
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,12 @@ using v8::BackingStore;
1818
using v8::BackingStoreInitializationMode;
1919
using v8::Context;
2020
using v8::FunctionCallbackInfo;
21+
using v8::HandleScope;
2122
using v8::Isolate;
2223
using v8::Local;
2324
using v8::Object;
2425
using v8::ObjectTemplate;
26+
using v8::SnapshotCreator;
2527
using v8::String;
2628
using v8::Uint8Array;
2729
using v8::Value;
@@ -32,7 +34,7 @@ void BindingData::MemoryInfo(MemoryTracker* tracker) const {
3234
}
3335

3436
BindingData::BindingData(Realm* realm,
35-
v8::Local<v8::Object> object,
37+
Local<Object> object,
3638
InternalFieldInfo* info)
3739
: SnapshotableObject(realm, object, type_int),
3840
encode_into_results_buffer_(
@@ -52,7 +54,7 @@ BindingData::BindingData(Realm* realm,
5254
}
5355

5456
bool BindingData::PrepareForSerialization(Local<Context> context,
55-
v8::SnapshotCreator* creator) {
57+
SnapshotCreator* creator) {
5658
DCHECK_NULL(internal_field_info_);
5759
internal_field_info_ = InternalFieldInfoBase::New<InternalFieldInfo>(type());
5860
internal_field_info_->encode_into_results_buffer =
@@ -74,7 +76,7 @@ void BindingData::Deserialize(Local<Context> context,
7476
int index,
7577
InternalFieldInfoBase* info) {
7678
DCHECK_IS_SNAPSHOT_SLOT(index);
77-
v8::HandleScope scope(context->GetIsolate());
79+
HandleScope scope(context->GetIsolate());
7880
Realm* realm = Realm::GetCurrent(context);
7981
// Recreate the buffer in the constructor.
8082
InternalFieldInfo* casted_info = static_cast<InternalFieldInfo*>(info);
@@ -194,7 +196,7 @@ void BindingData::DecodeUTF8(const FunctionCallbackInfo<Value>& args) {
194196
args.GetReturnValue().Set(ret);
195197
}
196198

197-
void BindingData::ToASCII(const v8::FunctionCallbackInfo<v8::Value>& args) {
199+
void BindingData::ToASCII(const FunctionCallbackInfo<Value>& args) {
198200
Environment* env = Environment::GetCurrent(args);
199201
CHECK_GE(args.Length(), 1);
200202
CHECK(args[0]->IsString());
@@ -207,7 +209,7 @@ void BindingData::ToASCII(const v8::FunctionCallbackInfo<v8::Value>& args) {
207209
}
208210
}
209211

210-
void BindingData::ToUnicode(const v8::FunctionCallbackInfo<v8::Value>& args) {
212+
void BindingData::ToUnicode(const FunctionCallbackInfo<Value>& args) {
211213
Environment* env = Environment::GetCurrent(args);
212214
CHECK_GE(args.Length(), 1);
213215
CHECK(args[0]->IsString());

0 commit comments

Comments
 (0)