Skip to content

Commit a4806e2

Browse files
richardlauMylesBorins
authored andcommitted
build: speed up source tarball creation
Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: #34508 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
1 parent f7600d5 commit a4806e2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/build-tarball.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ jobs:
2626
run: |
2727
export DISTTYPE=nightly
2828
export DATESTRING=`date "+%Y-%m-%d"`
29-
export COMMIT=xxxx
30-
./configure && make tar -j8
29+
export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
30+
./configure && make tar -j8 SKIP_XZ=1
3131
mkdir tarballs
3232
mv *.tar.gz tarballs
3333
- name: Upload tarball artifact

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1034,7 +1034,7 @@ pkg-upload: pkg
10341034
scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
10351035
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"
10361036

1037-
$(TARBALL): release-only $(NODE_EXE) doc
1037+
$(TARBALL): release-only doc-only
10381038
git checkout-index -a -f --prefix=$(TARNAME)/
10391039
mkdir -p $(TARNAME)/doc/api
10401040
cp doc/node.1 $(TARNAME)/doc/node.1

0 commit comments

Comments
 (0)