fs: fix when path is buffer on fs.symlinkSync

PR-URL: #34540
Fixes: #34514
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Pranshu Srivastava <[email protected]>

Author: himself65

lib/internal/fs/utils.js

@@ -349,6 +349,7 @@ function preprocessSymlinkDestination(path, type, linkPath) {
     // No preprocessing is needed on Unix.
     return path;
   }
+  path = '' + path;
   if (type === 'junction') {
     // Junctions paths need to be absolute and \\?\-prefixed.
     // A relative target is relative to the link's parent directory.
@@ -360,7 +361,7 @@ function preprocessSymlinkDestination(path, type, linkPath) {
     return pathModule.toNamespacedPath(path);
   }
   // Windows symlinks don't tolerate forward slashes.
-  return ('' + path).replace(/\//g, '\\');
+  return path.replace(/\//g, '\\');
 }
 
 // Constructor for file stats.

test/parallel/test-fs-symlink.js

@@ -51,6 +51,10 @@ fs.symlink(linkData, linkPath, common.mustSucceed(() => {
   fs.readlink(linkPath, common.mustSucceed((destination) => {
     assert.strictEqual(destination, linkData);
   }));
+
+  tmpdir.refresh();
+  // Fixes: https://github.com./nodejs/node/issues/34514
+  fs.symlinkSync(Buffer.from(linkData), linkPath);
 }));
 
 // Test invalid symlink