Skip to content

Commit 6f87fea

Browse files
ruyadornocjihrig
authored andcommitted
doc: add author-ready label ref to onboarding doc
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: #34381 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Myles Borins <[email protected]>
1 parent 9b353c6 commit 6f87fea

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

doc/guides/onboarding-extras.md

+13-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,19 @@ request.
2424
* `tsc-agenda` - Open issues and pull requests with this label will be added to
2525
the Technical Steering Committee meeting agenda
2626

27-
--
27+
---
28+
29+
* `author-ready` - A pull request is _author ready_ when:
30+
* There is a CI run in progress or completed.
31+
* There is at least one Collaborator approval (or two TSC approvals
32+
for semver-major PRs).
33+
* There are no outstanding review comments.
34+
35+
Please always add the `author ready` label to the pull request in that case.
36+
Please always remove it again as soon as the conditions are not met anymore,
37+
such as if CI run fails or a new outstanding review comment is posted.
38+
39+
---
2840

2941
* `semver-{minor,major}`
3042
* be conservative – that is, if a change has the remote *chance* of breaking

0 commit comments

Comments
 (0)