Skip to content

Commit 0d28527

Browse files
artmakstargos
authored andcommitted
http: destructure primordials in lib/_http_server.js
PR-URL: #30315 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent e1a63a9 commit 0d28527

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

lib/_http_server.js

+12-7
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,12 @@
2121

2222
'use strict';
2323

24-
const { Object } = primordials;
24+
const {
25+
Object: {
26+
setPrototypeOf: ObjectSetPrototypeOf,
27+
keys: ObjectKeys,
28+
}
29+
} = primordials;
2530

2631
const net = require('net');
2732
const assert = require('internal/assert');
@@ -162,8 +167,8 @@ function ServerResponse(req) {
162167
};
163168
}
164169
}
165-
Object.setPrototypeOf(ServerResponse.prototype, OutgoingMessage.prototype);
166-
Object.setPrototypeOf(ServerResponse, OutgoingMessage);
170+
ObjectSetPrototypeOf(ServerResponse.prototype, OutgoingMessage.prototype);
171+
ObjectSetPrototypeOf(ServerResponse, OutgoingMessage);
167172

168173
ServerResponse.prototype._finish = function _finish() {
169174
DTRACE_HTTP_SERVER_RESPONSE(this.socket);
@@ -254,8 +259,8 @@ function writeHead(statusCode, reason, obj) {
254259
// Slow-case: when progressive API and header fields are passed.
255260
let k;
256261
if (obj) {
257-
const keys = Object.keys(obj);
258-
for (let i = 0; i < keys.length; i++) {
262+
const keys = ObjectKeys(obj);
263+
for (var i = 0; i < keys.length; i++) {
259264
k = keys[i];
260265
if (k) this.setHeader(k, obj[k]);
261266
}
@@ -337,8 +342,8 @@ function Server(options, requestListener) {
337342
this.maxHeadersCount = null;
338343
this.headersTimeout = 40 * 1000; // 40 seconds
339344
}
340-
Object.setPrototypeOf(Server.prototype, net.Server.prototype);
341-
Object.setPrototypeOf(Server, net.Server);
345+
ObjectSetPrototypeOf(Server.prototype, net.Server.prototype);
346+
ObjectSetPrototypeOf(Server, net.Server);
342347

343348

344349
Server.prototype.setTimeout = function setTimeout(msecs, callback) {

0 commit comments

Comments
 (0)