Skip to content

Wasm tests on Windows are failing on gyp-next and this repo #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cclauss opened this issue Mar 19, 2025 · 4 comments · Fixed by #3145
Closed

Wasm tests on Windows are failing on gyp-next and this repo #3144

cclauss opened this issue Mar 19, 2025 · 4 comments · Fixed by #3145

Comments

@cclauss
Copy link
Contributor

cclauss commented Mar 19, 2025

I don't have a good solution to fix the wasm test right now. I think we should disable it before we have a proper fix.

/cc author of the tests, @toyobayashi I'd appreciate it if you could help us fixing the test, thanks!

Originally posted by @legendecas in #3143 (comment)

@nodejs/wasi @nodejs/wasi

@toyobayashi
Copy link
Contributor

The quickest solution is to install wasi-sdk in CI and then modify the path of clang.exe in the test code. If you agree to introduce additional dependencies, I can try to fix it. If you don't want to introduce additional dependencies, I think it's okay to skip the wasm test. I will open issue again if I encounter problems in the future. @legendecas @cclauss

@cclauss
Copy link
Contributor Author

cclauss commented Mar 19, 2025

Great. Please try first on the gyp-next repo and then we can upgrade this repo from that one.

@cclauss cclauss pinned this issue Mar 19, 2025
@legendecas
Copy link
Member

The test is in this repo, not in gyp-next (gyp-next is failing because we run node-gyp tests in it).

@cclauss
Copy link
Contributor Author

cclauss commented Mar 19, 2025

Confusing relationship between these two repos but OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants