Skip to content

Commit 8f0765e

Browse files
committed
lib: ignore non-critical os.userInfo() failures
Fixes: #1834
1 parent bacf53d commit 8f0765e

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

lib/install.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
'use strict'
2-
31
const fs = require('graceful-fs')
42
const os = require('os')
53
const tar = require('tar')
@@ -370,7 +368,12 @@ function install (fs, gyp, argv, callback) {
370368
}
371369
var tmpdir = os.tmpdir()
372370
gyp.devDir = path.resolve(tmpdir, '.node-gyp')
373-
log.warn('EACCES', 'user "%s" does not have permission to access the dev dir "%s"', os.userInfo().username, devDir)
371+
var userString = ''
372+
try {
373+
// os.userInfo can fail on some systems, it's not critical here
374+
userString = ` ("${os.userInfo().username}")`
375+
} catch (e) {}
376+
log.warn('EACCES', 'current user%s does not have permission to access the dev dir "%s"', userString, devDir)
374377
log.warn('EACCES', 'attempting to reinstall using temporary dev dir "%s"', gyp.devDir)
375378
if (process.cwd() === tmpdir) {
376379
log.verbose('tmpdir == cwd', 'automatically will remove dev files after to save disk space')

0 commit comments

Comments
 (0)