Skip to content

Commit 268f1ca

Browse files
Refael Ackermannbnoordhuis
Refael Ackermann
authored andcommitted
Use result of which when searching for python.
Fixes: #667 Fixes: #750 PR-URL: #668 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 817ed9b commit 268f1ca

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/configure.js

+4
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,10 @@ function findPython (python, callback) {
331331
}
332332
} else {
333333
log.verbose('`which` succeeded', python, execPath)
334+
// Found the `python` exceutable, and from now on we use it explicitly.
335+
// This solves #667 and #750 (`execFile` won't run batch files
336+
// (*.cmd, and *.bat))
337+
python = execPath
334338
checkPythonVersion()
335339
}
336340
})

0 commit comments

Comments
 (0)