detection of lite ci is broken again?

[sam-github]

I recall this was broken, then @richardlau fixed it, but now it seems to be broken again, I get No ci runs detected on nodejs/node#28178 and nodejs/node#28162

core/node (master $% u=) % node --version
v12.4.0
core/node (master $% u=) % git node --version
1.17.1

(just updated)

Am I(we?) doing something wrong?

[sam-github]

/cc @mhdawson

[richardlau]

Currently testing out with nodejs/node#28178 but it looks like it currently needs /pipeline at the end of the commented url:

node-core-utils/lib/ci/ci_type_parser.js

Lines 86 to 91 in 8d64553

	[LITE_PR_PIPELINE, {
	name: 'Lite PR Pipeline',
	jobName: 'node-test-pull-request-lite-pipeline',
	pattern: /node-test-pull-request-lite-pipeline\/(\d+)\/pipeline/,
	type: LITE_CI
	}],

I think when the bot was able to autostart jobs it would post the lite ci's with /pipeline at the end. In any case we should probably try to make the regexp not require the /pipeline suffix.

[richardlau]

-bash-4.2$ node ../node-core-utils/bin/git-node land 28162
✔  Done loading data for nodejs/node/pull/28162
----------------------------------- PR info ------------------------------------
Title      doc: update kernel and glibc reqs for PPCle (#28162)
Author     Michael Dawson <[email protected]> (@mhdawson)
Branch     mhdawson:ppcversions -> nodejs:master
Labels     author ready, build, doc
Commits    3
 - doc: update kernel and glibc reqs for PPCle
 - squash: address comments
 - squash: also update toolchains section.
Committers 2
 - Michael Dawson <[email protected]>
 - GitHub <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com./nodejs/node/pull/28162
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
--------------------------------------------------------------------------------
   ℹ  Last Lite PR Pipeline CI on 2019-06-13T15:11:00Z: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3678/
   ℹ  This PR was created on Mon, 10 Jun 2019 23:28:35 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau): https://github.com./nodejs/node/pull/28162#pullrequestreview-248173213
   ✔  - Sam Roberts (@sam-github) (TSC): https://github.com./nodejs/node/pull/28162#pullrequestreview-248329140
   ✔  - Rich Trott (@Trott) (TSC): https://github.com./nodejs/node/pull/28162#pullrequestreview-249479102
   ✔  - Beth Griggs (@BethGriggs): https://github.com./nodejs/node/pull/28162#pullrequestreview-249482474
--------------------------------------------------------------------------------
? This PR should be ready to land, do you want to continue?

PR incoming.