Skip to content

Commit eaee1a6

Browse files
authored
jenkins: check successful response before reading
While having a look at recent error logs, this fatal log stood out: ``` 02:48:11.721 FATAL bot: Unchaught exception, terminating bot process immediately TypeError: Cannot read property 'data' of undefined at githubClient.pullRequests.getCommits (/.../github-bot/lib/push-jenkins-update.js:92:29) at module.exports.sendError (/.../github-bot/node_modules/github/lib/index.js:874:7) at /.../github-bot/node_modules/github/lib/index.js:882:21 at callCallback (/.../github-bot/node_modules/github/lib/index.js:738:9) at IncomingMessage.<anonymous> (/.../github-bot/node_modules/github/lib/index.js:807:13) at IncomingMessage.emit (events.js:194:15) at endReadableNT (_stream_readable.js:1125:12) at process._tickCallback (internal/process/next_tick.js:63:19) ``` Since we never want these kinds of errors to happen since they end up killing the bot process, this fix is pushed to ensure we don't naively read the response from github.com. until we know the request didn't fail for some reason. Refs #246
1 parent 4cce2b9 commit eaee1a6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/push-jenkins-update.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ function findLatestCommitInPr (options, cb, pageNumber = 1) {
8989
page: pageNumber,
9090
per_page: 100
9191
}, (err, res) => {
92-
const commitMetas = res.data || []
9392
if (err) {
9493
return cb(err)
9594
}
9695

96+
const commitMetas = res.data || []
9797
const lastPageURL = githubClient.hasLastPage(res)
9898
if (lastPageURL) {
9999
return findLatestCommitInPr(options, cb, pageNumberFromURL(lastPageURL))

0 commit comments

Comments
 (0)