Skip to content

Commit 23b3444

Browse files
committed
Code review changes
1 parent 5d5d476 commit 23b3444

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

src/NHibernate/Hql/Ast/ANTLR/Tree/FromElement.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ public FromElement RealOrigin
315315
public SqlString WithClauseFragment
316316
{
317317
get { return _withClauseFragment; }
318-
set => _withClauseFragment = value;
318+
set { _withClauseFragment = value; }
319319
}
320320

321321
// Since 5.4

src/NHibernate/SqlCommand/ANSIJoinFragment.cs

+5-13
Original file line numberDiff line numberDiff line change
@@ -48,29 +48,21 @@ public override void AddJoin(string tableName, string alias, string[] fkColumns,
4848

4949
internal static string GetJoinString(JoinType joinType)
5050
{
51-
string joinString;
5251
switch (joinType)
5352
{
5453
case JoinType.InnerJoin:
55-
joinString = " inner join ";
56-
break;
54+
return " inner join ";
5755
case JoinType.LeftOuterJoin:
58-
joinString = " left outer join ";
59-
break;
56+
return " left outer join ";
6057
case JoinType.RightOuterJoin:
61-
joinString = " right outer join ";
62-
break;
58+
return " right outer join ";
6359
case JoinType.FullJoin:
64-
joinString = " full outer join ";
65-
break;
60+
return " full outer join ";
6661
case JoinType.CrossJoin:
67-
joinString = " cross join ";
68-
break;
62+
return " cross join ";
6963
default:
7064
throw new AssertionFailure("undefined join type");
7165
}
72-
73-
return joinString;
7466
}
7567

7668
public override SqlString ToFromFragmentString

0 commit comments

Comments
 (0)