Skip to content

Lint action missing errors on PRs #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kate-osborn opened this issue Oct 12, 2023 · 0 comments · Fixed by #1172
Closed

Lint action missing errors on PRs #1136

kate-osborn opened this issue Oct 12, 2023 · 0 comments · Fixed by #1172
Assignees
@sjberman
Labels
chore Pull requests for routine tasks

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Oct 12, 2023 •
edited
Loading

Describe the bug
The lint action passed on the PR but failed on the merge to main.

PR run: https://github.com./nginxinc/nginx-gateway-fabric/actions/runs/6499218551
Merge to main run: https://github.com./nginxinc/nginx-gateway-fabric/actions/runs/6499802831/job/17654089998

The pre-commit hook also missed this error.

Expected behavior

  • All lint errors should be caught before merging a PR to main.
  • Pre-commit hook should catch all lint errors
@kate-osborn kate-osborn mentioned this issue Oct 12, 2023
Merged
6 tasks
@sjberman sjberman self-assigned this Oct 20, 2023
@sjberman sjberman mentioned this issue Oct 20, 2023
Merged
6 tasks
@sjberman sjberman added the chore Pull requests for routine tasks label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pre-commit and action linter sjberman/nginx-gateway-fabric
2 participants
@sjberman @kate-osborn