Skip to content

Retry on status update failures #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpstefan opened this issue Aug 30, 2023 · 0 comments · Fixed by #1062
Closed

Retry on status update failures #1016

mpstefan opened this issue Aug 30, 2023 · 0 comments · Fixed by #1062
Assignees
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone

Comments

@mpstefan
Copy link
Member

mpstefan commented Aug 30, 2023

As a user of NKG
I want NKG to retry on status update failures
So that transient issues within Kubernetes do not prevent NKG from updating the status on its resources and leading me down a wrong debugging path when something goes wrong.

Acceptance

-When NKG fails to update status on a Kubernetes resource, it will retry if a relevant error is returned

  • A small back off is implemented for each retry
  • When the NKG pod context is cancelled, the status updater component will gracefully exit.

Original Issue:
It doesn't retry on failures. This means there is a chance that some resources will not have up-to-do statuses.
Statuses are important part of the Gateway API, so we need to ensure that the Gateway always keep the resources
statuses up-to-date.

@mpstefan mpstefan added this to the v1.0.0 milestone Sep 6, 2023
@mpstefan mpstefan added enhancement New feature or request size/small Estimated to be completed within ~2 days refined Requirements are refined and the issue is ready to be implemented. labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants