Skip to content

Make recipeYield optional #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DeaeLunae opened this issue Jun 14, 2022 · 3 comments · Fixed by #1108
Closed

Make recipeYield optional #1042

DeaeLunae opened this issue Jun 14, 2022 · 3 comments · Fixed by #1108
Assignees
Labels
enhancement New feature or request

Comments

@DeaeLunae
Copy link

Is your feature request related to a problem? Please describe.
Not all recipes have a serving size, as they are components and not final dish. "Apple pie" make have 8 servings, but "Custom pie crust" used in "apple pie" doesn't mesh.

Describe the solution you'd like
Ability to not show Servings on a recipe page

Describe alternatives you've considered
I also don't like the date created/modified tags and found I could just remove them from the json to have them not show up. Not the case for "servings" however. It just sits there mocking me.

@DeaeLunae DeaeLunae added the enhancement New feature or request label Jun 14, 2022
@christianlupus christianlupus self-assigned this Jul 15, 2022
@christianlupus
Copy link
Collaborator

I am trying to implement the backend part of this issue in a current update of the php code case.

If you would help with the design and the frontend, @TheMBeat or others, that would be very useful.

@TheMBeat
Copy link
Contributor

I could try to implement the UI, maybe a simple Checkbox to set the value to null.

@christianlupus
Copy link
Collaborator

Let me finish my current work related to the upgrade of recipe parsing and filtering. Once this is prepared, we can make the frontend compatible (again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants