Skip to content

Commit f88a32b

Browse files
Merge pull request #607 from nextcloud/dev/pretty-vue-files
Usage of prettier in order to have a clear coding standard
2 parents 341f444 + 483033a commit f88a32b

33 files changed

+2813
-1912
lines changed

.github/workflows/tests.yml

+28-24
Original file line numberDiff line numberDiff line change
@@ -8,30 +8,34 @@ on:
88
jobs:
99

1010
php-lint:
11-
name: Run PHP Linter and Code Style checker
12-
runs-on: ubuntu-latest
13-
steps:
14-
- name: Checkout the project
15-
uses: actions/checkout@v2
16-
- name: Get PHP version
17-
shell: bash
18-
run: php -v
19-
- name: Install Composer
20-
shell: bash
21-
run: >-
22-
wget https://github.com./composer/getcomposer.org/raw/master/web/installer -O - -q |
23-
php -- --quiet
24-
- name: Install packages
25-
shell: bash
26-
run: composer install
27-
- name: Run linter
28-
shell: bash
29-
run: composer lint:lint
30-
- name: Run code style checker
31-
shell: bash
32-
env:
33-
PHP_CS_FIXER_IGNORE_ENV: 1
34-
run: composer cs:check
11+
name: Run PHP Linter and Code Style checker
12+
runs-on: ubuntu-latest
13+
steps:
14+
- name: Checkout the project
15+
uses: actions/checkout@v2
16+
- name: Get PHP version
17+
shell: bash
18+
run: php -v
19+
- name: Install Composer
20+
shell: bash
21+
run: >-
22+
wget https://github.com./composer/getcomposer.org/raw/master/web/installer -O - -q |
23+
php -- --quiet
24+
- name: Install packages
25+
shell: bash
26+
run: composer install
27+
- name: Run linter
28+
shell: bash
29+
run: composer lint:lint
30+
- name: Run code style checker
31+
shell: bash
32+
env:
33+
PHP_CS_FIXER_IGNORE_ENV: 1
34+
run: composer cs:check
35+
- name: Check for formatting issues with vue files
36+
shell: bash
37+
run: npm run prettier
38+
3539

3640
unit-tests:
3741
name: Run the unittests

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
[#596](https://github.com./nextcloud/cookbook/pull/596) @seyfeb
66
- Updated dependency of eslint-config-prettier
77
[#603](https://github.com./nextcloud/cookbook/pull/603) @christianlupus
8+
- Enforce basic code styling using prettier in vue files
9+
[#607](https://github.com./nextcloud/cookbook/pull/607) @christianlupus
810

911
## Deprecated
1012
- Obsolete routes to old user interface, see `appinfo/routes.php`

0 commit comments

Comments
 (0)