Skip to content

fix(messaging): readme file rename instructions do not work #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

delaneyb
Copy link
Contributor

When placing the file YourAppName.entitlements in app/App_Resources/iOS/ I noticed Apple sign in and push notifications both stopped working. It appears the entitlements file should actually be called app.entitlements to be picked up by the cli. This PR corrects the advice given in the Messaging Readme.

Tested with
NativeScript CLI "version": "8.0.2"
Platform MacOS

@cla-bot cla-bot bot added the cla: yes label Oct 31, 2022
@triniwiz triniwiz merged commit 162e9d8 into NativeScript:main Oct 31, 2022
@delaneyb delaneyb deleted the messaging-readme-fix branch November 3, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants