fix(ios/core): filter out nil values from serialize
method
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase analytics'
logEvent
method fails on iOS when there's an array with null/undefined elements and when objects have null/undefined prop values.With this PR the null elements are filtered out of arrays and dictionaries.
This PR also fixes a slight oversight with
data.map(serialize)
, since this syntax causes the second argument to be the element index instead ofwrapPrimitives
, causing the first element not to be wrapped and all the others to be.firebase-database
might have the same issue since it declares its own version of the serialize method, but I haven't tested it.