fix(firestore)(android): arrayUnion always appends null to array (#150)

delaneyb · web-flow · commit e1b09f599e98 · 2022-11-02T11:47:59.000-04:00
diff --git a/packages/firebase-firestore/index.android.ts b/packages/firebase-firestore/index.android.ts
@@ -1118,11 +1118,11 @@ export class FieldValue implements IFieldValue {
 	}
 
 	static arrayRemove(elements: any[]): FieldValue {
-		return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayRemove(elements.map((element) => element?.native || element)));
+		return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayRemove(elements.map((element) => element?.native || serializeItems(element))));
 	}
 
 	static arrayUnion(elements: any[]): FieldValue {
-		return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayUnion(elements.map((element) => element?.native || element)));
+		return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayUnion(elements.map((element) => element?.native || serializeItems(element))));
 	}
 
 	static delete(): FieldValue {

Original file line number	Diff line number	Diff line change
`@@ -1118,11 +1118,11 @@ export class FieldValue implements IFieldValue {`
`1118`	`1118`	`}`
`1119`	`1119`
`1120`	`1120`	`static arrayRemove(elements: any[]): FieldValue {`
`1121`		`- return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayRemove(elements.map((element) => element?.native \|\| element)));`
	`1121`	`+ return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayRemove(elements.map((element) => element?.native \|\| serializeItems(element))));`
`1122`	`1122`	`}`
`1123`	`1123`
`1124`	`1124`	`static arrayUnion(elements: any[]): FieldValue {`
`1125`		`- return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayUnion(elements.map((element) => element?.native \|\| element)));`
	`1125`	`+ return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayUnion(elements.map((element) => element?.native \|\| serializeItems(element))));`
`1126`	`1126`	`}`
`1127`	`1127`
`1128`	`1128`	`static delete(): FieldValue {`