fix(dynamic-links): ios parameters builder assigned to wrong variable (#162)

mukaschultze · web-flow · commit a4a5c457f170 · 2022-12-05T12:04:57.000-04:00
diff --git a/packages/firebase-dynamic-links/.eslintrc.json b/packages/firebase-dynamic-links/.eslintrc.json
@@ -1,6 +1,6 @@
 {
 	"extends": ["../../.eslintrc.json"],
-	"ignorePatterns": ["!**/*", "node_modules/**/*"],
+	"ignorePatterns": ["!**/*", "node_modules/**/*", "typings/**/*"],
 	"overrides": [
 		{
 			"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
diff --git a/packages/firebase-dynamic-links/index.android.ts b/packages/firebase-dynamic-links/index.android.ts
@@ -142,7 +142,7 @@ export class DynamicLinkIOSParameters implements IDynamicLinkIOSParameters {
 	_bundleId: string;
 	constructor(bundleId?: string) {
 		this._bundleId = bundleId;
-		this._native = new com.google.firebase.dynamiclinks.DynamicLink.IosParameters.Builder(bundleId);
+		this._builder = new com.google.firebase.dynamiclinks.DynamicLink.IosParameters.Builder(bundleId);
 	}
 
 	static fromNative(link: com.google.firebase.dynamiclinks.DynamicLink.IosParameters) {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": ["../../.eslintrc.json"],`
`3`		`- "ignorePatterns": ["!*/", "node_modules/*/"],`
	`3`	`+ "ignorePatterns": ["!*/", "node_modules/*/", "typings/*/"],`
`4`	`4`	`"overrides": [`
`5`	`5`	`{`
`6`	`6`	`"files": [".ts", ".tsx", ".js", ".jsx"],`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ export class DynamicLinkIOSParameters implements IDynamicLinkIOSParameters {`
`142`	`142`	`_bundleId: string;`
`143`	`143`	`constructor(bundleId?: string) {`
`144`	`144`	`this._bundleId = bundleId;`
`145`		`- this._native = new com.google.firebase.dynamiclinks.DynamicLink.IosParameters.Builder(bundleId);`
	`145`	`+ this._builder = new com.google.firebase.dynamiclinks.DynamicLink.IosParameters.Builder(bundleId);`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`static fromNative(link: com.google.firebase.dynamiclinks.DynamicLink.IosParameters) {`