feat(NODE-4721): add aws-sdk as optional dependency #3446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
commented
Oct 17, 2022
| { | ||
| func: 'install dependencies', | ||
| vars: { | ||
| NPM_OPTIONS: '--no-optional' |
There was a problem hiding this comment.
We run the aws tests twice each now, once with the sdk installed and once without.
durran
commented
Oct 17, 2022
| @@ -308,7 +308,7 @@ const AWS_AUTH_TASKS = []; | |||
|
|
|||
| for (const VERSION of AWS_AUTH_VERSIONS) { | |||
| const name = ex => `aws-${VERSION}-auth-test-${ex.split(' ').join('-')}`; | |||
| const aws_funcs = [ | |||
| const awsFuncs = [ | |||
There was a problem hiding this comment.
Just changing name to JS conventions.
nbbeeken
approved these changes
Oct 17, 2022
|
The install size of the Mostly because of this new dependency being added. Can we please remove it from this package and instruct users to add this dependency in their project, if needed? EDIT: |
ZLY201
pushed a commit
to ZLY201/node-mongodb-native
that referenced
this pull request
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the AWS-SDK for finding credentials when present in dependencies, otherwise uses the internal implementation.
What is changing?
Patch build with AWS tests for with and without the optional dependencies:
https://spruce.mongodb.com/version/634d68f92fbabe2d0a6b964f/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Is there new documentation needed for these changes?
Can make a note to users that they can install the SDK to have it be used.
What is the motivation for this change?
NODE-4721
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>