-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-4133): array field NestedPaths return type #3184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @boenfu thanks for catching this! I'm going to investigate if there's a way we can add a test for why this autocomplete did not work. If you have any ideas our typescript tests for the cc: @baileympearson |
Okey ~ I added two test cases to prove that the type hint was fixed. The command Is there anything else I can help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the testing! this LGTM
(I tried the fix locally in my VScode too, works)
Description
What is changing?
before:


after:
Is there new documentation needed for these changes?
not need
What is the motivation for this change?
a tsc build error occurred for our specific requirements, after locating the cause several times, I think it is good for everyone, so fix it
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>