-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-3675): SRV option bug correctly defaults authSource to $external #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81ce532
to
0e57cfb
Compare
I've chosen to replace any checks for external auth mechanisms (e.g. This is mainly a choice of grouping these three as the external auth source mechanisms explicitly. Does this introduce too much confusion / make things less readable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
What is changing?
Previously, for external mechanisms, it was not always the case that
authSource
defaulted to$external
even though that was the intended behavior / what the spec outlines. External auth source mechanisms are now explicitly checked for inconnection_string
to avoid errant overrides (e.g. authSource = admin over $external). Unit tests added as well.Is there new documentation needed for these changes?
n/a
[ jira ]
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>