Skip to content

Commit f8bdb8d

Browse files
committed
fix(connect): listen to secureConnect for tls connections
1 parent d13b153 commit f8bdb8d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/core/connection/connect.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ function makeConnection(family, options, cancellationToken, _callback) {
281281
socket.setTimeout(connectionTimeout);
282282
socket.setNoDelay(noDelay);
283283

284+
const connectEvent = useSsl ? 'secureConnect' : 'connect';
284285
let cancellationHandler;
285286
function errorHandler(eventName) {
286287
return err => {
@@ -289,7 +290,7 @@ function makeConnection(family, options, cancellationToken, _callback) {
289290
cancellationToken.removeListener('cancel', cancellationHandler);
290291
}
291292

292-
socket.removeListener('connect', connectHandler);
293+
socket.removeListener(connectEvent, connectHandler);
293294
callback(connectionFailureError(eventName, err));
294295
};
295296
}
@@ -314,7 +315,7 @@ function makeConnection(family, options, cancellationToken, _callback) {
314315
cancellationToken.once('cancel', cancellationHandler);
315316
}
316317

317-
socket.once('connect', connectHandler);
318+
socket.once(connectEvent, connectHandler);
318319
}
319320

320321
const CONNECTION_ERROR_EVENTS = ['error', 'close', 'timeout', 'parseError'];

0 commit comments

Comments
 (0)