refactor: simplify error handling checks

Author: mbroadst

lib/core/sdam/server.js

@@ -240,14 +240,14 @@ class Server extends EventEmitter {
     }
 
     wireProtocol.command(this, ns, cmd, options, (err, result) => {
-      if (err && err instanceof MongoNetworkError) {
-        if (options.session) {
+      if (err) {
+        if (options.session && err instanceof MongoNetworkError) {
           options.session.serverSession.isDirty = true;
         }
-      }
 
-      if (err && isSDAMUnrecoverableError(err)) {
-        this.emit('error', err);
+        if (isSDAMUnrecoverableError(err)) {
+          this.emit('error', err);
+        }
       }
 
       callback(err, result);
@@ -264,14 +264,14 @@ class Server extends EventEmitter {
    */
   query(ns, cmd, cursorState, options, callback) {
     wireProtocol.query(this, ns, cmd, cursorState, options, (err, result) => {
-      if (err && err instanceof MongoNetworkError) {
-        if (options.session) {
+      if (err) {
+        if (options.session && err instanceof MongoNetworkError) {
           options.session.serverSession.isDirty = true;
         }
-      }
 
-      if (err && isSDAMUnrecoverableError(err)) {
-        this.emit('error', err);
+        if (isSDAMUnrecoverableError(err)) {
+          this.emit('error', err);
+        }
       }
 
       callback(err, result);
@@ -288,14 +288,14 @@ class Server extends EventEmitter {
    */
   getMore(ns, cursorState, batchSize, options, callback) {
     wireProtocol.getMore(this, ns, cursorState, batchSize, options, (err, result) => {
-      if (err && err instanceof MongoNetworkError) {
-        if (options.session) {
+      if (err) {
+        if (options.session && err instanceof MongoNetworkError) {
           options.session.serverSession.isDirty = true;
         }
-      }
 
-      if (err && isSDAMUnrecoverableError(err)) {
-        this.emit('error', err);
+        if (isSDAMUnrecoverableError(err)) {
+          this.emit('error', err);
+        }
       }
 
       callback(err, result);
@@ -424,14 +424,14 @@ function executeWriteOperation(args, options, callback) {
   }
 
   return wireProtocol[op](server, ns, ops, options, (err, result) => {
-    if (err && err instanceof MongoNetworkError) {
-      if (options.session) {
+    if (err) {
+      if (options.session && err instanceof MongoNetworkError) {
         options.session.serverSession.isDirty = true;
       }
-    }
 
-    if (err && isSDAMUnrecoverableError(err)) {
-      server.emit('error', err);
+      if (isSDAMUnrecoverableError(err)) {
+        server.emit('error', err);
+      }
     }
 
     callback(err, result);