Skip to content

Commit ad6f67c

Browse files
committed
test(change-streams): use generated port numbers for mock server
This test would occaisionally flake out due to the use of a port number hard coded in a number of other tests. If we instead use the default behavior of the mock server, and generate the port number, we can avoid this in the future.
1 parent 0a8b6d4 commit ad6f67c

File tree

1 file changed

+32
-32
lines changed

1 file changed

+32
-32
lines changed

test/functional/change_stream_tests.js

+32-32
Original file line numberDiff line numberDiff line change
@@ -1328,7 +1328,7 @@ describe('Change Streams', function() {
13281328
};
13291329

13301330
co(function*() {
1331-
primaryServer = yield mock.createServer(32000, 'localhost');
1331+
primaryServer = yield mock.createServer();
13321332

13331333
var counter = 0;
13341334
primaryServer.setMessageHandler(request => {
@@ -1341,8 +1341,8 @@ describe('Change Streams', function() {
13411341
{
13421342
ismaster: true,
13431343
secondary: false,
1344-
me: 'localhost:32000',
1345-
primary: 'localhost:32000',
1344+
me: primaryServer.uri(),
1345+
primary: primaryServer.uri(),
13461346
tags: { loc: 'ny' }
13471347
},
13481348
defaultFields
@@ -1402,46 +1402,46 @@ describe('Change Streams', function() {
14021402
request.reply({ ok: 1 });
14031403
}
14041404
});
1405-
});
14061405

1407-
MongoClient.connect(
1408-
'mongodb://localhost:32000/',
1409-
{
1410-
socketTimeoutMS: 500,
1411-
validateOptions: true
1412-
},
1413-
function(err, client) {
1414-
assert.ifError(err);
1406+
MongoClient.connect(
1407+
`mongodb://${primaryServer.uri()}/`,
1408+
{
1409+
socketTimeoutMS: 500,
1410+
validateOptions: true
1411+
},
1412+
function(err, client) {
1413+
assert.ifError(err);
14151414

1416-
var fs = require('fs');
1417-
var theDatabase = client.db('integration_tests5');
1418-
var theCollection = theDatabase.collection('MongoNetworkErrorTestPromises');
1419-
var thisChangeStream = theCollection.watch(pipeline);
1415+
var fs = require('fs');
1416+
var theDatabase = client.db('integration_tests5');
1417+
var theCollection = theDatabase.collection('MongoNetworkErrorTestPromises');
1418+
var thisChangeStream = theCollection.watch(pipeline);
14201419

1421-
var filename = '/tmp/_nodemongodbnative_resumepipe.txt';
1422-
var outStream = fs.createWriteStream(filename);
1420+
var filename = '/tmp/_nodemongodbnative_resumepipe.txt';
1421+
var outStream = fs.createWriteStream(filename);
14231422

1424-
thisChangeStream.stream({ transform: JSON.stringify }).pipe(outStream);
1423+
thisChangeStream.stream({ transform: JSON.stringify }).pipe(outStream);
14251424

1426-
// Listen for changes to the file
1427-
var watcher = fs.watch(filename, function(eventType) {
1428-
assert.equal(eventType, 'change');
1425+
// Listen for changes to the file
1426+
var watcher = fs.watch(filename, function(eventType) {
1427+
assert.equal(eventType, 'change');
14291428

1430-
var fileContents = fs.readFileSync(filename, 'utf8');
1429+
var fileContents = fs.readFileSync(filename, 'utf8');
14311430

1432-
var parsedFileContents = JSON.parse(fileContents);
1433-
assert.equal(parsedFileContents.fullDocument.a, 1);
1431+
var parsedFileContents = JSON.parse(fileContents);
1432+
assert.equal(parsedFileContents.fullDocument.a, 1);
14341433

1435-
watcher.close();
1434+
watcher.close();
14361435

1437-
thisChangeStream.close(function(err) {
1438-
assert.ifError(err);
1436+
thisChangeStream.close(function(err) {
1437+
assert.ifError(err);
14391438

1440-
mock.cleanup(primaryServer, () => done());
1439+
mock.cleanup(primaryServer, () => done());
1440+
});
14411441
});
1442-
});
1443-
}
1444-
);
1442+
}
1443+
);
1444+
});
14451445
}
14461446
});
14471447

0 commit comments

Comments
 (0)