Skip to content

Commit 7ed6dbf

Browse files
authored
fix: Change socket timeout default to 0 (#2564)
Socket timeout by default is infinity. NODE-2835
1 parent 98162c3 commit 7ed6dbf

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/cmap/connect.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ function makeConnection(
277277
: typeof options.connectTimeoutMS === 'number'
278278
? options.connectTimeoutMS
279279
: 30000;
280-
const socketTimeout = typeof options.socketTimeout === 'number' ? options.socketTimeout : 360000;
280+
const socketTimeout = typeof options.socketTimeout === 'number' ? options.socketTimeout : 0;
281281
const rejectUnauthorized =
282282
typeof options.rejectUnauthorized === 'boolean' ? options.rejectUnauthorized : true;
283283

src/cmap/connection.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export class Connection extends EventEmitter {
9999
super(options);
100100
this.id = options.id;
101101
this.address = streamIdentifier(stream);
102-
this.socketTimeout = options.socketTimeout ?? 360000;
102+
this.socketTimeout = options.socketTimeout ?? 0;
103103
this.monitorCommands = options.monitorCommands ?? options.monitorCommands;
104104
this.closed = false;
105105
this.destroyed = false;

src/operations/connect.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ export function connect(
211211
const finalOptions = createUnifiedOptions(urlOptions, options);
212212

213213
// Check if we have connection and socket timeout set
214-
if (finalOptions.socketTimeoutMS == null) finalOptions.socketTimeoutMS = 360000;
214+
if (finalOptions.socketTimeoutMS == null) finalOptions.socketTimeoutMS = 0;
215215
if (finalOptions.connectTimeoutMS == null) finalOptions.connectTimeoutMS = 10000;
216216
if (finalOptions.retryWrites == null) finalOptions.retryWrites = true;
217217
if (finalOptions.useRecoveryToken == null) finalOptions.useRecoveryToken = true;
@@ -582,7 +582,7 @@ function translateOptions(options: any) {
582582
}
583583

584584
// Set the socket and connection timeouts
585-
if (options.socketTimeoutMS == null) options.socketTimeoutMS = 360000;
585+
if (options.socketTimeoutMS == null) options.socketTimeoutMS = 0;
586586
if (options.connectTimeoutMS == null) options.connectTimeoutMS = 10000;
587587

588588
const translations = {

0 commit comments

Comments
 (0)