test(NODE-6804): convert unhandled rejections into uncaught exceptions

Author: nbbeeken

.mocharc.js

@@ -7,6 +7,7 @@ module.exports = {
   require: [
     'source-map-support/register',
     'ts-node/register',
+    'test/tools/runner/throw_rejections.cjs',
     'test/tools/runner/chai_addons.ts',
     'test/tools/runner/ee_checker.ts'
   ],
@@ -17,5 +18,5 @@ module.exports = {
   reporter: 'test/tools/reporter/mongodb_reporter.js',
   sort: true,
   color: true,
-  'node-option': Number(major) >= 23 ? ['no-experimental-strip-types'] : undefined
+ 'node-option': Number(major) >= 23 ? ['no-experimental-strip-types'] : undefined
 };

package-lock.json

@@ -81,6 +81,7 @@
     "@types/whatwg-url": "^11.0.5",
     "@typescript-eslint/eslint-plugin": "8.4.0",
     "@typescript-eslint/parser": "8.4.0",
+    "aws4": "^1.13.2",
     "chai": "^4.4.1",
     "chai-subset": "^1.6.0",
     "chalk": "^4.1.2",

package.json

@@ -48,6 +48,7 @@ import {
   maxWireVersion,
   type MongoDBNamespace,
   noop,
+  squashError,
   supportsRetryableWrites
 } from '../utils';
 import { throwIfWriteConcernError } from '../write_concern';
@@ -345,10 +346,8 @@ export class Server extends TypedEventEmitter<ServerEvents> {
         operationError instanceof MongoError &&
         operationError.code === MONGODB_ERROR_CODES.Reauthenticate
       ) {
-        reauthPromise = this.pool.reauthenticate(conn).catch(error => {
-          reauthPromise = null;
-          throw error;
-        });
+        // TODO: what do we do with this error? the signal has aborted so where should it be delivered?
+        reauthPromise = this.pool.reauthenticate(conn).then(undefined, squashError);
 
         await abortable(reauthPromise, options);
         reauthPromise = null; // only reachable if reauth succeeds

src/sdam/server.ts

@@ -751,9 +751,10 @@ describe('AbortSignal support', () => {
         ...args
       ) {
         if (args[1].find != null) {
+          await sleep(1);
           commandStub.restore();
           controller.abort();
-          throw new ReAuthenticationError({});
+          throw new ReAuthenticationError({ message: 'This is a fake reauthentication error' });
         }
         return commandStub.wrappedMethod.apply(this, args);
       });
@@ -793,7 +794,7 @@ describe('AbortSignal support', () => {
       beforeEach(() => {
         sinon.stub(ConnectionPool.prototype, 'reauthenticate').callsFake(async function () {
           await sleep(1000);
-          throw new Error();
+          throw new Error('Rejecting reauthenticate for testing');
         });
       });
 

test/integration/node-specific/abort_signal.test.ts

@@ -4,7 +4,11 @@ const [major] = process.versions.node.split('.');
 
 /** @type {import("mocha").MochaOptions} */
 module.exports = {
-  require: ['ts-node/register', 'test/tools/runner/chai_addons.ts'],
+  require: [
+    'ts-node/register',
+    'test/tools/runner/throw_rejections.cjs',
+    'test/tools/runner/chai_addons.ts'
+  ],
   reporter: 'test/tools/reporter/mongodb_reporter.js',
   failZero: true,
   color: true,

test/manual/mocharc.js

@@ -4,7 +4,10 @@ const [major] = process.versions.node.split('.');
 
 /** @type {import("mocha").MochaOptions} */
 module.exports = {
-  require: ['test/integration/node-specific/examples/setup.js'],
+  require: [
+    'test/tools/runner/throw_rejections.cjs',
+    'test/integration/node-specific/examples/setup.js'
+  ],
   extension: ['js'],
   ui: 'test/tools/runner/metadata_ui.js',
   recursive: true,

test/mocha_lambda.js

@@ -7,6 +7,7 @@ module.exports = {
   require: [
     'source-map-support/register',
     'ts-node/register',
+    'test/tools/runner/throw_rejections.cjs',
     'test/tools/runner/chai_addons.ts',
     'test/tools/runner/ee_checker.ts',
     'test/tools/runner/hooks/configuration.ts',

test/mocha_mongodb.js

@@ -0,0 +1,6 @@
+// eslint-disable-next-line @typescript-eslint/no-require-imports
+const process = require('process');
+
+process.on('unhandledRejection', error => {
+  throw error;
+});

test/tools/runner/throw_rejections.cjs

@@ -0,0 +1,72 @@
+import { expect } from 'chai';
+import { existsSync } from 'fs';
+import { resolve } from 'path';
+
+import {
+  AuthContext,
+  compress,
+  GSSAPI,
+  HostAddress,
+  MongoDBAWS,
+  MongoMissingDependencyError
+} from '../../mongodb';
+
+function moduleExistsSync(moduleName) {
+  return existsSync(resolve(__dirname, `../../../node_modules/${moduleName}`));
+}
+
+describe('optionalRequire', function () {
+  describe('Snappy', function () {
+    it('should error if not installed', async function () {
+      const moduleName = 'snappy';
+      if (moduleExistsSync(moduleName)) {
+        return this.skip();
+      }
+
+      const error = await compress(
+        { zlibCompressionLevel: 0, agreedCompressor: 'snappy' },
+        Buffer.alloc(1)
+      ).then(
+        () => null,
+        e => e
+      );
+
+      expect(error).to.be.instanceOf(MongoMissingDependencyError);
+    });
+  });
+
+  describe('Kerberos', function () {
+    it('should error if not installed', async function () {
+      const moduleName = 'kerberos';
+      if (moduleExistsSync(moduleName)) {
+        return this.skip();
+      }
+      const gssapi = new GSSAPI();
+
+      const error = await gssapi
+        .auth(new AuthContext(null, true, { hostAddress: new HostAddress('a'), credentials: true }))
+        .then(
+          () => null,
+          e => e
+        );
+
+      expect(error).to.be.instanceOf(MongoMissingDependencyError);
+    });
+  });
+
+  describe('aws4', function () {
+    it('should error if not installed', async function () {
+      const moduleName = 'aws4';
+      if (moduleExistsSync(moduleName)) {
+        return this.skip();
+      }
+      const mdbAWS = new MongoDBAWS();
+
+      const error = await mdbAWS.auth(
+        new AuthContext({ hello: { maxWireVersion: 9 } }, true, null)
+      );
+
+      expect(error).to.be.instanceOf(MongoMissingDependencyError);
+    });
+  });
+});