feat(NODE-5958): add BSON iterating API #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Mar 8, 2024
nbbeeken
force-pushed
the
NODE-5958-parseToStructure
branch
from
ba55987 to
32d1204
Compare
aditi-khare-mongoDB
suggested changes
Mar 11, 2024
aditi-khare-mongoDB
added
the
Primary Review
nbbeeken
added
Team Review
aditi-khare-mongoDB
previously approved these changes
Mar 13, 2024
baileympearson
requested changes
Mar 13, 2024
W-A-James
reviewed
Mar 13, 2024
W-A-James
approved these changes
Mar 15, 2024
baileympearson
approved these changes
Mar 15, 2024
aditi-khare-mongoDB
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
To encapsulate the complexity of iterating into nested structures such that one can write a function responsible for reviving each BSON value as needed and decide whether or not to create a nested structure.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript