Skip to content

Related spans *probably* should all be 'message'? #25473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Jul 5, 2018 · 1 comment
Closed

Related spans *probably* should all be 'message'? #25473

DanielRosenwasser opened this issue Jul 5, 2018 · 1 comment
Assignees
@DanielRosenwasser
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue
Milestone
TypeScript 3.0.1

Comments

@DanielRosenwasser
Copy link
Member

Right now 7038 and 2728 use "Error" as their kind; but other related spans us "Message"
@mhegazy
Copy link
Contributor

mhegazy commented Jul 5, 2018

fix it @DanielRosenwasser!

@DanielRosenwasser DanielRosenwasser mentioned this issue Jul 6, 2018
Merged
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Fixed A PR has been merged for this issue Domain: Error Messages The issue relates to error messaging labels Jul 6, 2018
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.0.1 milestone Jul 6, 2018
@DanielRosenwasser DanielRosenwasser self-assigned this Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 3.0.1
Development

No branches or pull requests
2 participants
@DanielRosenwasser @mhegazy