-
Notifications
You must be signed in to change notification settings - Fork 12.8k
API: expose getEffectiveTypeParameterDeclarations #24248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It does have type parameters, it is just not on Can you filter out |
I initially reported it because it seemed unintuitive and maybe unintentional. Filtering out the JSDoc stuff would fix the compile error, but I'm actually interested in those type parameters. So this is now more a suggestion to expose |
that makes sense. a PR would be appreciated.. @sandersn any concerns? |
Ideally we would have either
Non-ideally, we would (1) would break existing users of the typeParameters property. (2) might or might not be feasible. I lean toward (3) but I'm not sure how bad the break of (1) is. |
Now that #24600 added more logic to |
@sandersn any chance this will make it into the 3.0.0 release? Otherwise I will probably rebuild that logic as part of my library |
Very high chance. However, the public API is temporarily broken because of the new build system, but that should be resolved in a day or two. In the meantime, I assigned myself so I don't forget and also added the help wanted tag in case somebody will have time to fix it before I do. |
TypeScript Version: 2.9.0-dev.20180518
Search Terms:
Code
Expected behavior:
No compile error. This used to work in 2.9.0-rc
Actual behavior:
Playground Link: not possible
Related Issues:
caused by #23947 @sandersn
The text was updated successfully, but these errors were encountered: