Skip to content

Commit b553aff

Browse files
authored
Fix smoke test substitution (#51494)
1 parent 021fd20 commit b553aff

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

.github/workflows/ci.yml

+12-8
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,14 @@ jobs:
109109
npm init --yes
110110
npm install $PACKAGE tslib
111111
112+
echo "Testing tsc..."
112113
npx tsc --version
114+
115+
echo "Testing tsserver..."
113116
echo '{"seq": 1, "command": "status"}' | npx tsserver
114117
115-
cat > smoke.js << EOF
118+
cat > smoke.js << 'EOF'
119+
console.log(`Testing ${process.argv[2]}...`);
116120
const { __importDefault, __importStar } = require("tslib");
117121
const ts = require(process.argv[2]);
118122
@@ -132,16 +136,16 @@ jobs:
132136
success = !!fn();
133137
}
134138
catch {}
135-
if (success !== shouldSucceed) {
136-
if (success) {
137-
console.error(`${fn.toString()} unexpectedly succeeded.`);
138-
}
139-
else {
140-
console.error(`${fn.toString()} did not succeed.`);
141-
}
139+
const status = success ? "succeeded" : "failed";
140+
if (success === shouldSucceed) {
141+
console.log(`${fn.toString()} ${status} as expected.`);
142+
}
143+
else {
144+
console.log(`${fn.toString()} unexpectedly ${status}.`);
142145
process.exitCode = 1;
143146
}
144147
}
148+
console.log("ok");
145149
EOF
146150
147151
node ./smoke.js typescript

0 commit comments

Comments
 (0)