Skip to content

Print right url info for faucet service #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kikakkz opened this issue Mar 18, 2025 · 2 comments
Open

Print right url info for faucet service #3587

kikakkz opened this issue Mar 18, 2025 · 2 comments

Comments

@kikakkz
Copy link
Contributor

kikakkz commented Mar 18, 2025 •
edited
Loading

Description
It always print localhost but listen on 0.0.0.0 currently.

Suggestion
I believe it's better to print the url with both localhost and lan ip urls.

Screenshot
Image
@ma2bd
Copy link
Contributor

ma2bd commented Mar 18, 2025

Technically, localhost (aka 127.0.0.1) is a subset of the addresses designated by 0.0.0.0

@kikakkz kikakkz mentioned this issue Mar 18, 2025
Closed
@kikakkz
Copy link
Contributor Author

kikakkz commented Mar 18, 2025

Technically, localhost (aka 127.0.0.1) is a subset of the addresses designated by 0.0.0.0

Yeah. Here I meant that we can give (maybe) two urls to users: http://localhost:8080 and http://$LAN_IP:8080.

I create a draft PR here: #3588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ma2bd @kikakkz