From 27ddf69269cbe3fbf4820d964d5a0bdcbcb54835 Mon Sep 17 00:00:00 2001 From: Mohd Hafizuddin M Marzuki Date: Sat, 8 Mar 2025 13:15:41 +0800 Subject: [PATCH 1/3] Set version=3 for roadrunner's reload --- src/RoadRunner/ServerProcessInspector.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/RoadRunner/ServerProcessInspector.php b/src/RoadRunner/ServerProcessInspector.php index 0e3133545..dfef42164 100644 --- a/src/RoadRunner/ServerProcessInspector.php +++ b/src/RoadRunner/ServerProcessInspector.php @@ -47,6 +47,7 @@ public function reloadServer(): void tap($this->processFactory->createProcess([ $this->findRoadRunnerBinary(), 'reset', + '-o', "version=3", '-o', "rpc.listen=tcp://$host:$rpcPort", '-s', ], base_path()))->start()->waitUntil(function ($type, $buffer) { From 41e3e08a53f4b8dc8adb2e71a49727ed5c6c41de Mon Sep 17 00:00:00 2001 From: Mohd Hafizuddin M Marzuki Date: Sat, 8 Mar 2025 13:24:55 +0800 Subject: [PATCH 2/3] Fix styling --- src/RoadRunner/ServerProcessInspector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/RoadRunner/ServerProcessInspector.php b/src/RoadRunner/ServerProcessInspector.php index dfef42164..a52728921 100644 --- a/src/RoadRunner/ServerProcessInspector.php +++ b/src/RoadRunner/ServerProcessInspector.php @@ -47,7 +47,7 @@ public function reloadServer(): void tap($this->processFactory->createProcess([ $this->findRoadRunnerBinary(), 'reset', - '-o', "version=3", + '-o', 'version=3', '-o', "rpc.listen=tcp://$host:$rpcPort", '-s', ], base_path()))->start()->waitUntil(function ($type, $buffer) { From 079d229a54b446c1473d8b99a349fea2743bb7cb Mon Sep 17 00:00:00 2001 From: Mohd Hafizuddin M Marzuki Date: Tue, 11 Mar 2025 06:21:50 +0800 Subject: [PATCH 3/3] Fix test --- tests/RoadRunnerServerProcessInspectorTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/RoadRunnerServerProcessInspectorTest.php b/tests/RoadRunnerServerProcessInspectorTest.php index 7d92095bb..10701e426 100644 --- a/tests/RoadRunnerServerProcessInspectorTest.php +++ b/tests/RoadRunnerServerProcessInspectorTest.php @@ -63,7 +63,7 @@ public function test_roadrunner_server_process_can_be_reloaded() ]); $processFactory->shouldReceive('createProcess')->with( - [$this->findRoadRunnerBinary(), 'reset', '-o', 'rpc.listen=tcp://127.0.0.1:6002', '-s'], + [$this->findRoadRunnerBinary(), 'reset', '-o', 'server=3', '-o', 'rpc.listen=tcp://127.0.0.1:6002', '-s'], base_path(), )->andReturn($process = Mockery::mock('stdClass'));