Skip to content

Commit f792c4f

Browse files
Update test plan
1 parent e1a6ad5 commit f792c4f

File tree

1 file changed

+26
-1
lines changed
  • keps/sig-windows/2802-identify-windows-pods-apiserver-admission

1 file changed

+26
-1
lines changed

keps/sig-windows/2802-identify-windows-pods-apiserver-admission/README.md

+26-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,32 @@ express scheduling constraints. During the alpha, we assume there are no schedul
186186
- Unit tests covering API server defaulting to various fields within pod with and without this feature
187187
- Unit tests covering admission plugins which validate/mutate pod spec based on this feature
188188
- Unit and E2E tests for Kubelet changes.
189-
- Updates to the `sig-windows` tagged tests to utilize to direct windows scheduling for all pods .
189+
- Updates to the `sig-windows` tagged tests to utilize to direct windows scheduling for all pods.
190+
191+
#### Prerequisite testing updates
192+
[x] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.
193+
194+
##### Unit tests
195+
196+
`k8s.io/kubernetes/pkg/apis/core/validation`: `06/03/2022` `82.1% of statements`
197+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:2979`: `06/03/2022`: `76.2% of statements`
198+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3488`: `06/03/2022`: `92.0% of statements`
199+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3573`: `06/03/2022`: `100.0% of statements`
200+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3590`: `06/03/2022`: `65.3% of statements`
201+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:6360`: `06/03/2022`: `100.0% of statements`
202+
203+
##### Integration tests
204+
205+
The pod security standard integration tests will be updated to include OS specific validations.
206+
207+
208+
##### e2e tests
209+
210+
There are e2e tests which
211+
- validate that the kubelet rejects the pod which have os field not matching the underlying OS
212+
- validate that the kubelet reconciles and corrects if the node's OS label is changed
213+
214+
190215
### Graduation Criteria
191216

192217
#### Alpha

0 commit comments

Comments
 (0)