Skip to content

Use a PluginRegistry for loading plugins #7615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtpio opened this issue Mar 20, 2025 · 0 comments · Fixed by #7616
Closed

Use a PluginRegistry for loading plugins #7615

jtpio opened this issue Mar 20, 2025 · 0 comments · Fixed by #7616
Labels
status:Needs Triage Applied to issues that need triage
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Mar 20, 2025

Current the NotebookApp does not make use of a PluginRegistry for loading plugins:

app.registerPluginModules(mods);

It also does not resolve ServiceManagerPlugins first as in JupyterLab.

Notebook should follow the same approach as in JupyterLab: https://github.com./jupyterlab/jupyterlab/blob/eaddbc7b6e8a13198edd9cdb156def78724f07e2/dev_mode/index.js#L260

As a follow-up to jupyterlab/jupyterlab#16794.

@jtpio jtpio added the status:Needs Triage Applied to issues that need triage label Mar 20, 2025
@jtpio jtpio added this to the 7.4.0 milestone Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:Needs Triage Applied to issues that need triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant