Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

not masking error message when starting daemon #896

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Jul 3, 2017

Reported in #894

@Kubuxu Kubuxu added the status/in-progress In progress label Jul 3, 2017
@daviddias daviddias merged commit ea8de20 into master Jul 4, 2017
@daviddias daviddias deleted the fix/daemon-start branch July 4, 2017 10:44
@daviddias daviddias removed the status/in-progress In progress label Jul 4, 2017
@daviddias
Copy link
Member

Thanks @pgte :)

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
BREAKING CHANGE: Object API refactor.

Object API methods that write DAG nodes now return a CID instead of a DAG node. Affected methods:

* `ipfs.object.new`
* `ipfs.object.patch.addLink`
* `ipfs.object.patch.appendData`
* `ipfs.object.patch.rmLink`
* `ipfs.object.patch.setData`
* `ipfs.object.put`

Example:

```js
// Before
const dagNode = await ipfs.object.new()
```

```js
// After
const cid = await ipfs.object.new() // now returns a CID
const dagNode = await ipfs.object.get(cid) // fetch the DAG node that was created
```

IMPORTANT: `DAGNode` instances, which are part of the IPLD dag-pb format have been refactored.

These instances no longer have `multihash`, `cid` or `serialized` properties.

This effects the following API methods that return these types of objects:

* `ipfs.object.get`
* `ipfs.dag.get`

See ipld/js-ipld-dag-pb#99 for more information.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants