-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Reduce Dexie.js's minified size #745
Comments
Just had a conversation on IRC with @dignifiedquire:
So it may be that the numbers here are incorrect. Will investigate, mark this issue as invalid for now, but don't close until we've verified that that's the case. |
Looking into the number as per ^, ran a quick test with ipfs-log:
The first is the normal minified build. The second is without Buffer included in the code. Normal: 73.50kb To me that looks like the numbers are minified sizes. Am I missing something @dignifiedquire? |
hmm looks like the second numbers are minified, interesting. Could you post the full log from the build with dexie please? |
Sure. This is the full output from building minified orbit-db:
Using [email protected] and UglifyJS#harmony. Comes from:
|
@haadcode could you test with this branch: ipfs/js-idb-pull-blob-store#17 this uses the latest dexie and directly uses the minified version |
Will do. Will also try with babili as discussed if the latest dexie still shows up big. |
From IRC:
So to sum it, with webpack 2, we need to run it with I think we can close this. Agreed @dignifiedquire? |
Oh, one more:
So, make sure to include "uglify-js": "github:mishoo/UglifyJS2#harmony" in your |
dexie is going away with new datastore, so no more worries :) Closing this one! |
Noticed that when I'm bundling (orbit-db with js-ipfs) with webpack, Dexie.js is at 199kb (in the minified build) but dexie's official minified build is 53kb.
We should check if we can reduce its sie to similar level as the official minified build. This would reduce the disk footprint of js-ipfs build.
The text was updated successfully, but these errors were encountered: