Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

feat(factory): add ipfs factory, verify it works with object tests #407

Merged
merged 3 commits into from
Aug 11, 2016
Merged

feat(factory): add ipfs factory, verify it works with object tests #407

merged 3 commits into from
Aug 11, 2016

Conversation

daviddias
Copy link
Member

@daviddias daviddias commented Aug 10, 2016 •
edited
Loading

  • create ipfsFactory
  • test it
  • make all interface-ipfs-core tests use ipfsFactory

@daviddias daviddias added the status/in-progress In progress label Aug 10, 2016
@daviddias daviddias force-pushed the feat/ipfs-factory branch 4 times, most recently from 6511617 to 893c310 Compare August 10, 2016 19:18
@daviddias
Copy link
Member Author

Up for CR

@dignifiedquire
Copy link
Member

Do we still need the rest of things in test/util?

@daviddias
Copy link
Member Author

@dignifiedquire we still need for now. I want to phase them out and use just IPFS factory.

@dignifiedquire
Copy link
Member

okay, lgtm if ci is happy

@daviddias daviddias force-pushed the feat/ipfs-factory branch 2 times, most recently from 3ef70b3 to 1e71a61 Compare August 11, 2016 09:29
@daviddias daviddias mentioned this pull request Aug 11, 2016
Closed
@daviddias daviddias merged commit 09740c2 into master Aug 11, 2016
@daviddias daviddias deleted the feat/ipfs-factory branch August 11, 2016 12:35
@daviddias daviddias removed the status/in-progress In progress label Aug 11, 2016
@daviddias
Copy link
Member Author

thank you :)

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
fix: allow only by object (ipfs#407)
1766ef4 
The only option will now accept an object for onlying a specific test.

Previously you could only do this to only run a specific test:

```js
{
  only: ['should test a thing']
}
```

Now you can do this:

```js
{
  only: [{
    name: 'should test a thing',
    reason: 'because development' // optional!
  }]
}
```

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @dignifiedquire