Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 990e804

Browse files
committed
fix: update with iso-stream-http
1 parent 3a4e986 commit 990e804

File tree

8 files changed

+15
-36
lines changed

8 files changed

+15
-36
lines changed

package.json

+8-10
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77
"browser": {
88
"glob": false,
99
"fs": false,
10-
"stream": "readable-stream",
11-
"http": "stream-http",
12-
"./src/utils/request.js": "./src/utils/request-browser.js"
10+
"stream": "readable-stream"
1311
},
1412
"scripts": {
1513
"test": "aegir test",
@@ -38,15 +36,16 @@
3836
"glob": "^7.1.3",
3937
"ipfs-block": "~0.8.0",
4038
"ipld-dag-cbor": "~0.13.1",
41-
"ipld-dag-pb": "~0.15.0",
42-
"is-ipfs": "~0.5.1",
39+
"ipld-dag-pb": "~0.15.3",
40+
"is-ipfs": "~0.6.0",
4341
"is-pull-stream": "0.0.0",
4442
"is-stream": "^1.1.0",
43+
"iso-stream-http": "~0.1.1",
4544
"iso-url": "~0.4.6",
4645
"just-kebab-case": "^1.1.0",
4746
"just-map-keys": "^1.1.0",
4847
"lru-cache": "^5.1.1",
49-
"multiaddr": "^6.0.5",
48+
"multiaddr": "^6.0.6",
5049
"multibase": "~0.6.0",
5150
"multicodec": "~0.5.0",
5251
"multihashes": "~0.4.14",
@@ -61,10 +60,9 @@
6160
"pump": "^3.0.0",
6261
"qs": "^6.5.2",
6362
"readable-stream": "^3.1.1",
64-
"stream-http": "hugomrdias/stream-http#develop",
6563
"stream-to-pull-stream": "^1.7.2",
6664
"tar-stream": "^2.0.1",
67-
"through2": "^3.0.0"
65+
"through2": "^3.0.1"
6866
},
6967
"engines": {
7068
"node": ">=10.0.0",
@@ -75,7 +73,7 @@
7573
"url": "https://github.com./ipfs/js-ipfs-http-client"
7674
},
7775
"devDependencies": {
78-
"aegir": "^18.2.0",
76+
"aegir": "^18.2.1",
7977
"browser-process-platform": "~0.1.1",
8078
"chai": "^4.2.0",
8179
"cross-env": "^5.2.0",
@@ -179,4 +177,4 @@
179177
"url": "https://github.com./ipfs/js-ipfs-http-client/issues"
180178
},
181179
"homepage": "https://github.com./ipfs/js-ipfs-http-client"
182-
}
180+
}

src/files-mfs/ls-readable-stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const {
44
Transform,
55
PassThrough
6-
} = require('stream')
6+
} = require('readable-stream')
77
const pump = require('pump')
88
const ndjson = require('ndjson')
99
const isStream = require('is-stream')

src/files-regular/add-from-url.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const promisify = require('promisify-es6')
44
const { URL } = require('iso-url')
5-
const request = require('../utils/request')
5+
const { getRequest } = require('iso-stream-http')
66
const SendOneFile = require('../utils/send-one-file-multiple-results')
77
const FileResultStreamConverter = require('../utils/file-result-stream-converter')
88

@@ -37,7 +37,7 @@ const validUrl = (url) => typeof url === 'string' && url.startsWith('http')
3737
const requestWithRedirect = (url, opts, sendOneFile, callback) => {
3838
const parsedUrl = new URL(url)
3939

40-
const req = request(parsedUrl.protocol)(url, (res) => {
40+
const req = getRequest(parsedUrl, (res) => {
4141
if (res.statusCode >= 400) {
4242
return callback(new Error(`Failed to download with ${res.statusCode}`))
4343
}

src/utils/multipart.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict'
22

3-
const Transform = require('stream').Transform
3+
const Transform = require('readable-stream').Transform
44
const isNode = require('detect-node')
55
const isSource = require('is-pull-stream').isSource
66
const toStream = require('pull-to-stream')

src/utils/request-browser.js

-7
This file was deleted.

src/utils/request.js

-12
This file was deleted.

src/utils/send-request.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ const isNode = require('detect-node')
66
const ndjson = require('ndjson')
77
const pump = require('pump')
88
const once = require('once')
9+
const { getRequest } = require('iso-stream-http')
910
const streamToValue = require('./stream-to-value')
1011
const streamToJsonValue = require('./stream-to-json-value')
11-
const request = require('./request')
1212
const log = require('debug')('ipfs-http-client:request')
1313

1414
// -- Internal
@@ -171,7 +171,7 @@ function requestAPI (config, options, callback) {
171171
protocol: `${config.protocol}:`
172172
}
173173

174-
const req = request(config.protocol)(reqOptions, onRes(options.buffer, callback))
174+
const req = getRequest(reqOptions, onRes(options.buffer, callback))
175175

176176
req.on('error', (err) => {
177177
callback(err)

test/get.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('.get (specific go-ipfs features)', function () {
2323

2424
const smallFile = {
2525
cid: 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP',
26-
data: fixture('js/test/fixtures/testfile.txt')
26+
data: fixture('test/fixtures/testfile.txt')
2727
}
2828

2929
let ipfsd

0 commit comments

Comments
 (0)