Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 7a47e3b

Browse files
michaelsbradleyjrAlan Shaw
authored and
Alan Shaw
committed
build: change min node version to 8.3.0 (#996)
Also adjust Travis CI config to perform builds and tests with node 8. `npm install`, `npm run build`, and `npm run test` all succeeded locally with node version `8.3.0`. The reason for version `8.3.0` instead of `8.0.0` is that `8.3.0` introduced support for object rest/spread, which is used by at least one of this package's devDependencies (`go-ipfs-dep`). It may be the case that at runtime older versions of node would work correctly with the built package, but it seems simpler to settle on the minimum supported version being a version that can build, test, and use the package. Closes #983.
1 parent f4b89ed commit 7a47e3b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ stages:
77

88
node_js:
99
- '10'
10+
- '8'
1011

1112
os:
1213
- linux

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"through2": "^3.0.1"
7171
},
7272
"engines": {
73-
"node": ">=10.0.0",
73+
"node": ">=8.3.0",
7474
"npm": ">=3.0.0"
7575
},
7676
"repository": {

0 commit comments

Comments
 (0)