You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Prior to this change the `ipld-dag-cbor` and `ipld-dag-pb` modules
are re-exported so that can be accessed within the Browser bundle.
Those modules normally don't need to be used directly, they are
kind of implementation details of IPLD. Hence remove them.
---
Re-exporting these types here effectively forces ipfs core implementation versions to follow versions of these packages. Their API is now our API. i.e. if dag-pb increments major, then ipfs has to also increment major even if the rest of the IPFS API has no breaking changes.
Keeping these in sync is also problematic - if we try to use an old dag-pb module with ipfs whose ipld has a newer dag-pb things can break. If at all, they should be exported from ipld and re-exported here, so that ipfs doesn't have to keep them in sync. However considering they should not be used directly for day-to-day operation I'm in agreement with them being removed.
0 commit comments